Remove calledRun debug checks. NFC#27135
Open
sbc100 wants to merge 1 commit into
Open
Conversation
Member
|
This might be redundant, but isn't it still useful? E.g. we might refactor away |
Collaborator
Author
|
I'm hoping to straighten out all this code in a followup do it will be less relevant then. Happy to wait and make this part of that change. |
Collaborator
Author
|
The removal of the Module property I would like to move forward with though, since that effects codesize of release builds #27133 |
This is redundant since there is already an assertion in `initRuntime` which is the first thing this function calls.
sbc100
force-pushed
the
remove_debug_calledRun
branch
from
269eab3 to
215ac63
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is redundant since there is already a similar assertion in
initRuntimewhich is the first thing this function calls.